storage: Remove "Partition" content tab #19189
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See #19170 for an example of the "Name" confusion. |
|
The tests needs adapting quite a bit. I'll do that once we have agreed that we really want to remove this tab. |
mvollmer
force-pushed
the
storage-no-partition-tab
branch
from
8a31c3a
to
99562d5
Compare
|
Indeed there isn't too much information there:
The size is already shown in the row header (progress bar), and the GPT UUIDs are indecipherable for a human as well. The type might be more useful on a classic MSDOS partition, though? Could this be moved as "Partition type" into the filesystem tab perhaps? |
|
I have no strong opinion here... we can also leave it as it is until we get to it during the redesign. |
|
We will probably want to eventually offer resizing of partitions, so we need a partition specific place for that... hmm. |
Cockpit does not allow setting or changing any of the information shown in this content tab, and the "Name" can easily be confused with the "Name" in the "Filesystem" content tab. Also, the less tabs we have, the easier the move to a new layout without any tabs will be.
mvollmer
force-pushed
the
storage-no-partition-tab
branch
from
99562d5
to
5fcc125
Compare
|
Let's not do this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cockpit does not allow setting or changing any of the information shown in this content tab, and the "Name" can easily be confused with the "Name" in the "Filesystem" content tab.
Also, the less tabs we have, the easier the move to a new layout without any tabs will be.